Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31834 )
Change subject: google/chromeos: Support AP watchdog flag from Chrome EC ......................................................................
Patch Set 9:
(5 comments)
https://review.coreboot.org/c/coreboot/+/31834/3/src/ec/google/chromeec/Kcon... File src/ec/google/chromeec/Kconfig:
https://review.coreboot.org/c/coreboot/+/31834/3/src/ec/google/chromeec/Kcon... PS3, Line 27: config EC_GOOGLE_CHROMEEC_AP_WATCHDOG_FLAG
Good idea! […]
Done
https://review.coreboot.org/c/coreboot/+/31834/4/src/ec/google/chromeec/ec.c File src/ec/google/chromeec/ec.c:
https://review.coreboot.org/c/coreboot/+/31834/4/src/ec/google/chromeec/ec.c... PS4, Line 745: }
Ack
Ack
https://review.coreboot.org/c/coreboot/+/31834/4/src/ec/google/chromeec/ec.c... PS4, Line 747: #ifndef __PRE_RAM__
Thanks for the explanation.
__PRE_RAM__ has been removed.
https://review.coreboot.org/c/coreboot/+/31834/5/src/ec/google/chromeec/ec_c... File src/ec/google/chromeec/ec_commands.h:
https://review.coreboot.org/c/coreboot/+/31834/5/src/ec/google/chromeec/ec_c... PS5, Line 4824: #define RESET_FLAG_AP_WATCHDOG (1 << 18) /* AP experienced a watchdog reset */
I have uploaded two CLs for ec_commands.h changes: […]
Done
https://review.coreboot.org/c/coreboot/+/31834/5/src/vendorcode/google/chrom... File src/vendorcode/google/chromeos/watchdog.c:
https://review.coreboot.org/c/coreboot/+/31834/5/src/vendorcode/google/chrom... PS5, Line 51: if (!CONFIG(CHROMEOS_USE_EC_WATCHDOG_FLAG)) {
Sounds good. Done.
Done