Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34561 )
Change subject: Documentation/soc/amd: Add Family 15h ......................................................................
Patch Set 8:
(14 comments)
https://review.coreboot.org/c/coreboot/+/34561/8/Documentation/soc/amd/famil... File Documentation/soc/amd/family15h.md:
https://review.coreboot.org/c/coreboot/+/34561/8/Documentation/soc/amd/famil... PS8, Line 5: Family 15h (Bulldozer) is a microprocessor microarchitecture first released in : 2011. What about something like
Family 15h is a line of AMD products first introduced in 2011. The initial microarchitecture, codenamed "Bulldozer", introduced...
You can then mention the other microarchitecture names, however I don't think they warrant much discussion of what each brought into play.
I'm not sure I would say it "evolved" into five models. In fact, looking around I see at least one more. So maybe be nonspecific here.
https://review.coreboot.org/c/coreboot/+/34561/8/Documentation/soc/amd/famil... PS8, Line 8: threads cores
https://review.coreboot.org/c/coreboot/+/34561/8/Documentation/soc/amd/famil... PS8, Line 9: thread core
https://review.coreboot.org/c/coreboot/+/34561/8/Documentation/soc/amd/famil... PS8, Line 13: replaces replace
https://review.coreboot.org/c/coreboot/+/34561/8/Documentation/soc/amd/famil... PS8, Line 13: Family 15h [SOC|Processors] products are x86-based designs that replaces previous : SMT schema with CMT Huh? AMD never had SMT in a previous product.
https://review.coreboot.org/c/coreboot/+/34561/8/Documentation/soc/amd/famil... PS8, Line 14: .. 2 periods
https://review.coreboot.org/c/coreboot/+/34561/8/Documentation/soc/amd/famil... PS8, Line 22: . All families weren't identical. I would either be less specific here or perhaps clarify you're talking about the initial BD uarch. Maybe add that resource sharing changed in the later families and other performance improvements were introduced.
https://review.coreboot.org/c/coreboot/+/34561/8/Documentation/soc/amd/famil... PS8, Line 24: A die also includes Some products include
https://review.coreboot.org/c/coreboot/+/34561/8/Documentation/soc/amd/famil... PS8, Line 26: (grounding a pin I would remove this
https://review.coreboot.org/c/coreboot/+/34561/8/Documentation/soc/amd/famil... PS8, Line 27: validated how about authenticated
https://review.coreboot.org/c/coreboot/+/34561/8/Documentation/soc/amd/famil... PS8, Line 31: _AGESA ™_). _AGESA_ Why are you italicizing?
https://review.coreboot.org/c/coreboot/+/34561/8/Documentation/soc/amd/famil... PS8, Line 37: _Merlin Falcon_) and 70h-7Fh (_Stoney Ridge_) Why are you italicizing?
https://review.coreboot.org/c/coreboot/+/34561/8/Documentation/soc/amd/famil... PS8, Line 40: ## Additional Definitions I'm not sure you need additional definitions anymore. You described PSP above and FCH isn't used anywhere else in the document. Not all Family 15h contain an integrated FCH.
https://review.coreboot.org/c/coreboot/+/34561/8/Documentation/soc/amd/famil... PS8, Line 45: extra whitespace?