Attention is currently required from: Harsha B R, Haribalaraman Ramasubramanian, Rizwan Qureshi, Sridhar Siricilla, Balaji Manigandan, Krishna P Bhat D, Usha P.
Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69396 )
Change subject: mb/intel/mtlrvp: Configure devicetree and GPIOs for Meteor Lake-P
......................................................................
Patch Set 10: Code-Review+1
(2 comments)
File src/mainboard/intel/mtlrvp/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/69396/comment/a7b4d40f_2211c6b0
PS10, Line 67: # RP configuration
put RP setting under RP port would be easier to reading.
File src/mainboard/intel/mtlrvp/gpio.c:
https://review.coreboot.org/c/coreboot/+/69396/comment/3aaac664_fb25ebf1
PS10, Line 3: #include <console/console.h>
nit: alphabet order.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/69396
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3173c3f32b36d24467431df3652badd70efeab93
Gerrit-Change-Number: 69396
Gerrit-PatchSet: 10
Gerrit-Owner: Harsha B R
harsha.b.r@intel.com
Gerrit-Reviewer: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Haribalaraman Ramasubramanian
haribalaraman.r@intel.com
Gerrit-Reviewer: Harsha B R
harsha.b.r@intel.com
Gerrit-Reviewer: Krishna P Bhat D
krishna.p.bhat.d@intel.com
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Usha P
usha.p@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Harsha B R
harsha.b.r@intel.com
Gerrit-Attention: Haribalaraman Ramasubramanian
haribalaraman.r@intel.com
Gerrit-Attention: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Attention: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Attention: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-Attention: Krishna P Bhat D
krishna.p.bhat.d@intel.com
Gerrit-Attention: Usha P
usha.p@intel.com
Gerrit-Comment-Date: Tue, 22 Nov 2022 00:23:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment