Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46432 )
Change subject: security/vboot: Make mrc_cache hash functions generic ......................................................................
Patch Set 7:
(2 comments)
https://review.coreboot.org/c/coreboot/+/46432/1/src/security/vboot/mrc_cach... File src/security/vboot/mrc_cache_hash_tpm.c:
https://review.coreboot.org/c/coreboot/+/46432/1/src/security/vboot/mrc_cach... PS1, Line 28: if (!vboot_recovery_mode_enabled())
I think it's okay to have the RW MRC hash enabled for FSP2. […]
For now I've split the current CL into CL1-5. I still have to do CL6-8.
https://review.coreboot.org/c/coreboot/+/46432/4/src/security/vboot/secdata_... File src/security/vboot/secdata_tpm.c:
https://review.coreboot.org/c/coreboot/+/46432/4/src/security/vboot/secdata_... PS4, Line 169: assert(!CONFIG(TPM1));
This is already in the #if CONFIG(TPM2) block (see line 89), so this check is redundant. […]
Removed.