[coreboot-gerrit] Change in coreboot[master]: herobrine: get boardid from GPIO configuration

[Ravi Kumar Bokka (Code Review)]

Attention is currently required from: Shelley Chen, Ravi kumar, Paul Menzel.
Ravi Kumar Bokka has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55950 )

Change subject: herobrine: get boardid from GPIO configuration
......................................................................

Patch Set 5:

(1 comment)

File src/mainboard/google/herobrine/boardid.c:

https://review.coreboot.org/c/coreboot/+/55950/comment/2f28be8f_6894c4a5 
PS5, Line 25: CB_ERR
> Can CB_ERR be interpreted as an actual board_id?  Should we just return UNDEFINED_STRAPPING_ID inste […]

hi shelly,
If we return "#define UNDEFINED_STRAPPING_ID  (~0)" it may confuse the actual board id's for sku variants.

#define QCOM_SC7280_SKU1 0x0
#define QCOM_SC7280_SKU2 0x1
#define QCOM_SC7280_SKU3 0x2

so i have keep CB_ERR.

please correct me if anything wrong here.