Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47614 )
Change subject: nb/intel/sandybridge: Use one sequence for write leveling ......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/47614/1/src/northbridge/intel/sandy... File src/northbridge/intel/sandybridge/raminit_common.c:
https://review.coreboot.org/c/coreboot/+/47614/1/src/northbridge/intel/sandy... PS1, Line 1725: if (ctrl->rank_mirror[channel][slotrank]) : ddr3_mirror_mrreg(&bank, &mr1reg); This looks like a functional difference. Maybe mention it in the commit message?