Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39769 )
Change subject: nb/intel/haswell: Implement proper backlight PWM config ......................................................................
Patch Set 6: Code-Review+1
(2 comments)
https://review.coreboot.org/c/coreboot/+/39769/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39769/4//COMMIT_MSG@15 PS4, Line 15: variants was overridden with 200Hz like it was for the Broadwell
Where was it overridden? By Linux?
Done
https://review.coreboot.org/c/coreboot/+/39769/4/src/northbridge/intel/haswe... File src/northbridge/intel/haswell/gma.c:
https://review.coreboot.org/c/coreboot/+/39769/4/src/northbridge/intel/haswe... PS4, Line 370: }
Please add some debug messages, or is there another way to deduce the settings from the coreboot log […]
Done