Nico Huber has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/57431 )
Change subject: ec/acpi: Remove empty "chip" driver ......................................................................
ec/acpi: Remove empty "chip" driver
There was no code attached to this driver and hence one couldn't hook it up to any device. Even if mentioned in the `devicetree.cb` it was still dead code.
Change-Id: I12415ea9e0120b1d00524f8f39f9b2d02f46ba05 Signed-off-by: Nico Huber nico.h@gmx.de --- M src/ec/acpi/ec.c M src/mainboard/getac/p470/devicetree.cb M src/mainboard/roda/rk886ex/devicetree.cb 3 files changed, 0 insertions(+), 9 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/57431/1
diff --git a/src/ec/acpi/ec.c b/src/ec/acpi/ec.c index a60de27..5d6fb18 100644 --- a/src/ec/acpi/ec.c +++ b/src/ec/acpi/ec.c @@ -148,7 +148,3 @@ ec_cmd_reg = cmd_reg; ec_data_reg = data_reg; } - -struct chip_operations ec_acpi_ops = { - CHIP_NAME("ACPI Embedded Controller") -}; diff --git a/src/mainboard/getac/p470/devicetree.cb b/src/mainboard/getac/p470/devicetree.cb index 94ffd19..9a91b81 100644 --- a/src/mainboard/getac/p470/devicetree.cb +++ b/src/mainboard/getac/p470/devicetree.cb @@ -123,8 +123,6 @@ end device pnp 4e.b off # HWM end - chip ec/acpi - end end
end diff --git a/src/mainboard/roda/rk886ex/devicetree.cb b/src/mainboard/roda/rk886ex/devicetree.cb index b19b7af..6b9dbd9 100644 --- a/src/mainboard/roda/rk886ex/devicetree.cb +++ b/src/mainboard/roda/rk886ex/devicetree.cb @@ -99,9 +99,6 @@ device pnp ff.1 on # dummy address end end - chip ec/acpi - end - end device pci 1f.1 off end # IDE device pci 1f.2 on end # SATA