Peter Lemenkov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33867 )
Change subject: mb/lenovo: Add Lenovo Thinkpad Helix
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/33867/1/src/mainboard/lenovo/helix/Kconfig
File src/mainboard/lenovo/helix/Kconfig:
PS1:
Configure the following options: […]
* MAINBOARD_VENDOR is selected in top-level Kconfig (from mb/lenovo directory)
* MAINBOARD_PCI_SUBSYSTEM_DEVICE_ID and MAINBOARD_PCI_SUBSYSTEM_DEVICE_ID were removed with commit 75380d3a162aa5864c8864923f621806b32e2f23
* PXE_ROM_ID was configured only by mb/up/squared mainboard - is it really necessary?
* CBFS_SIZE isn't used in most recent supported Lenovo mainboards - is it necessary?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33867
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7dbf10bc85edb161fce077568d4ef3db91e10db7
Gerrit-Change-Number: 33867
Gerrit-PatchSet: 1
Gerrit-Owner: Christoph Pomaska
github@aufmachen.jetzt
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Christoph Pomaska
github@aufmachen.jetzt
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Peter Lemenkov
lemenkov@gmail.com
Gerrit-Comment-Date: Mon, 01 Jul 2019 12:57:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer
felixsinger@posteo.net
Gerrit-MessageType: comment