Attention is currently required from: Nico Huber, Sean Rhodes.
Hello build bot (Jenkins), Nico Huber,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/74406
to look at the new patch set (#4).
Change subject: soc/intel/common/rtd3: Use D3COLD_SUPPORT to set max sleep state ......................................................................
soc/intel/common/rtd3: Use D3COLD_SUPPORT to set max sleep state
Use D3COLD_SUPPORT Kconfig option to set the maximum support sleep state. Report `4` in `_S0W` only when D3COLD_SUPPORT is enabled, as if it is not, it will break S3 exit.
When D3COLD_SUPPORT is not enabled, return `3` (D3Hot).
This fixed S3 exit on both TGL and ADL. Tested on StarBook Mk V and Mk VI.
Signed-off-by: Sean Rhodes sean@starlabs.systems Change-Id: I578d4933b6144aec79fe0b2eb168338ef82c0b9d --- M src/soc/intel/common/block/pcie/rtd3/rtd3.c 1 file changed, 23 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/74406/4