Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34582 )
Change subject: soc/intel/common/block/uart: Update the UART PCI device reference
......................................................................
Patch Set 6:
(3 comments)
https://review.coreboot.org/c/coreboot/+/34582/5//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/34582/5//COMMIT_MSG@11
PS5, Line 11: refernce
reference
Done
https://review.coreboot.org/c/coreboot/+/34582/5/src/soc/intel/common/block/...
File src/soc/intel/common/block/uart/uart.c:
https://review.coreboot.org/c/coreboot/+/34582/5/src/soc/intel/common/block/...
PS5, Line 76: if (!dev)
: return;
Nit: As `device` is already checked by the caller, and the `pci_devfn_t` […]
Done
https://review.coreboot.org/c/coreboot/+/34582/5/src/soc/intel/common/block/...
PS5, Line 147: return;
Nit: This looks odd with the empty line above but none below.
Done. Added a blank line below
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34582
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie0fe5991f3b0b9c596c3de9472e98e4091d7dd87
Gerrit-Change-Number: 34582
Gerrit-PatchSet: 6
Gerrit-Owner: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-CC: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 30 Jul 2019 10:37:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment