Attention is currently required from: Federico Amedeo Izzo, Felix Singer, Paul Menzel.
Felix Held has posted comments on this change by Federico Amedeo Izzo. ( https://review.coreboot.org/c/coreboot/+/82010?usp=email )
Change subject: mb/aoostar: Add Alder Lake based AOOSTAR R1 (WTR_R1)
......................................................................
Patch Set 16:
(1 comment)
File src/mainboard/aoostar/wtr_r1/gpio.h:
PS14:
Thank you for the heads up! I figured out running `intelp2m` with `-n` does exactly that. […]
ah, good to know that the intelp2m tool has a command line switch to generate code using the higher level macros
--
To view, visit
https://review.coreboot.org/c/coreboot/+/82010?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I9414eb742b6b90459e010b038c1994537e9801a5
Gerrit-Change-Number: 82010
Gerrit-PatchSet: 16
Gerrit-Owner: Federico Amedeo Izzo
federico@izzo.pro
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Brandon Weeks
bweeks@google.com
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-Attention: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Federico Amedeo Izzo
federico@izzo.pro
Gerrit-Comment-Date: Mon, 27 May 2024 14:07:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Federico Amedeo Izzo
federico@izzo.pro
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de