Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45336 )
Change subject: soc/intel/common/block: Add Intel common reset code ......................................................................
Patch Set 7:
(2 comments)
https://review.coreboot.org/c/coreboot/+/45336/7/src/soc/intel/common/block/... File src/soc/intel/common/block/reset/reset.c:
https://review.coreboot.org/c/coreboot/+/45336/7/src/soc/intel/common/block/... PS7, Line 27: do_force_global_reset
First we should try to send global reset using CSE command GLOBAL_RESET if failure then we will use […]
Sure, I just don't like the naming scheme :-)
First, I'd like to find a better name for do_global_reset, since naming whise it's not clear what the difference between global_reset vs. do_global_reset is. That's simply confusing. (another, exaggerated example would be having global_reset, do_global_reset, really_do_global_reset, really_really_do_global_reset, ...) You know what I mean?
Second, do_global_reset is only ever called from do_force_global_reset, so why not move the prior to the latter?
https://review.coreboot.org/c/coreboot/+/45336/7/src/soc/intel/common/block/... PS7, Line 34: !! isn't one enough?