Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47697 )
Change subject: mb/google/octopus: fix droid lte sku load specific wifi sar value ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47697/2/src/mainboard/google/octopu... File src/mainboard/google/octopus/variants/bobba/variant.c:
https://review.coreboot.org/c/coreboot/+/47697/2/src/mainboard/google/octopu... PS2, Line 24: if (sku_id == 33 || sku_id == 34 || sku_id == 35 || sku_id == 36 || sku_id == 37 || : sku_id == 38 || sku_id == 39 || sku_id == 40 || sku_id == 41 || sku_id == 42 || : sku_id == 43 || sku_id == 44) Looking at the continuity in the sku_id, can be simplified as
if (sku_id >= 33 && sku_id <= 44) filename = "wifi_sar-droid.hex";