Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37829 )
Change subject: asus/am1i-a: Switch away from ROMCC_BOOTBLOCK ......................................................................
Patch Set 1:
(4 comments)
Thanks!
https://review.coreboot.org/c/coreboot/+/37829/1/src/mainboard/asus/am1i-a/b... File src/mainboard/asus/am1i-a/bootblock.c:
https://review.coreboot.org/c/coreboot/+/37829/1/src/mainboard/asus/am1i-a/b... PS1, Line 123: pm_write8(0xd2, 0x0); already in hudson/bootblock.c
https://review.coreboot.org/c/coreboot/+/37829/1/src/mainboard/asus/am1i-a/b... PS1, Line 125: /* Disable PCI-PCI bridge and release GPIO32/33 for other uses. */ Can you check datasheet if this is valid for fam16kb.
https://review.coreboot.org/c/coreboot/+/37829/1/src/mainboard/asus/am1i-a/b... PS1, Line 129: pm_write8(0x24, 0x1); already in hudson/bootblock.c
BTW: pm_write8 only works with AcpiMmio enabled
https://review.coreboot.org/c/coreboot/+/37829/1/src/mainboard/asus/am1i-a/b... PS1, Line 150: * because of the buffer ICS551M If we believe the comments we do not need this.
For "Larne" which I believe is codename for some CRB, super-io might be add-on debug device carrying LPC signals on a cable. Not sure. Marshall?