Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/29429 )
Change subject: mb/google/poppy/variant/nocturne: use PLTRST for FPMCU_INT_L ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/#/c/29429/2/src/mainboard/google/poppy/variants/... File src/mainboard/google/poppy/variants/nocturne/gpio.c:
https://review.coreboot.org/#/c/29429/2/src/mainboard/google/poppy/variants/... PS2, Line 134: PLTRST If you change this to PLTRST, doesn't it reset the GPIO state on entry into S3? which would prevent the device from waking the system?
https://review.coreboot.org/#/c/29429/2/src/mainboard/google/poppy/variants/... PS2, Line 138: PLTRST So does it mean that there was some pending interrupt that wasn't getting handled by the kernel driver? And hence resetting the GPIO state prevents that interrupt from happening and hence the storm?