Kyösti Mälkki has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38184 )
Change subject: drivers/pc80/rtc: Enable normal/fallback without USE_OPTION_TABLE ......................................................................
drivers/pc80/rtc: Enable normal/fallback without USE_OPTION_TABLE
Due the !USE_OPTION_TABLE it always booted to fallback.
Change-Id: I44eb50df4389d1ac9e4c746f53654aff1055d400 Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com --- M src/drivers/pc80/rtc/mc146818rtc_boot.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/84/38184/1
diff --git a/src/drivers/pc80/rtc/mc146818rtc_boot.c b/src/drivers/pc80/rtc/mc146818rtc_boot.c index c009d67..307b1cf 100644 --- a/src/drivers/pc80/rtc/mc146818rtc_boot.c +++ b/src/drivers/pc80/rtc/mc146818rtc_boot.c @@ -84,7 +84,7 @@ { unsigned char byte;
- if (!CONFIG(USE_OPTION_TABLE) || cmos_error() || !cmos_chksum_valid()) { + if (cmos_error() || (CONFIG(USE_OPTION_TABLE) && !cmos_chksum_valid())) { /* Invalid CMOS checksum detected! * Force fallback boot... */