Yidi Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46393 )
Change subject: soc/mediatek/mt8192: Init DPM ......................................................................
Patch Set 41:
(3 comments)
https://review.coreboot.org/c/coreboot/+/46393/40//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/46393/40//COMMIT_MSG@8 PS40, Line 8:
Add a short description on what is DPM.
Done
https://review.coreboot.org/c/coreboot/+/46393/40/src/soc/mediatek/mt8192/Ma... File src/soc/mediatek/mt8192/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/46393/40/src/soc/mediatek/mt8192/Ma... PS40, Line 56: $(CONFIG_DPM_DM_FIRMWARE) \ : $(CONFIG_DPM_PM_FIRMWARE) \ : $(CONFIG_MCUPM_FIRMWARE) \
No need to put \ in same column. […]
Done
https://review.coreboot.org/c/coreboot/+/46393/40/src/soc/mediatek/mt8192/dp... File src/soc/mediatek/mt8192/dpm.c:
https://review.coreboot.org/c/coreboot/+/46393/40/src/soc/mediatek/mt8192/dp... PS40, Line 33: dpm_mcu[0].load_buffer = _dram_dma; : dpm_mcu[0].buffer_size = REGION_SIZE(dram_dma); : dpm_mcu[1].load_buffer = _dram_dma; : dpm_mcu[1].buffer_size = REGION_SIZE(dram_dma); : : /* config DPM SRAM layout */ : clrsetbits32(&mtk_dpm->sw_rstn, DPM_MEM_RATIO_MASK, DPM_MEM_RATIO_CFG1); : : if (mtlib_init_mcu(&dpm_mcu[0])) : return -1; : if (mtlib_init_mcu(&dpm_mcu[1])) : return -1;
int i; […]
Done