Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38546 )
Change subject: Make MP init timeout configurable ......................................................................
Patch Set 1:
(4 comments)
https://review.coreboot.org/c/coreboot/+/38546/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38546/1//COMMIT_MSG@7 PS1, Line 7: Make MP init timeout configurable
Please add a prefix: […]
Ack
https://review.coreboot.org/c/coreboot/+/38546/1//COMMIT_MSG@10 PS1, Line 10: Xeon scalable processor, the timeout needs to be adjusted.
What sort of timing are you seeing and why? It could certainly be made to be larger. […]
We are working on Xeon-SP based server platform. The multi-socket bring-up and communication is quite different and more complex than other SoC families. Hence we need the MP init timeout to be much larger.
https://review.coreboot.org/c/coreboot/+/38546/1/src/cpu/x86/Kconfig File src/cpu/x86/Kconfig:
https://review.coreboot.org/c/coreboot/+/38546/1/src/cpu/x86/Kconfig@192 PS1, Line 192: Time-out (in micro seconds) to wait for APs to check-in
- No second tab. […]
Done
https://review.coreboot.org/c/coreboot/+/38546/1/src/cpu/x86/mp_init.c File src/cpu/x86/mp_init.c:
https://review.coreboot.org/c/coreboot/+/38546/1/src/cpu/x86/mp_init.c@525 PS1, Line 525: const int timeout_us = CONFIG_FLIGHT_PLAN_TIMEOUT_US;
Agreed.
It is oaky for me to simply increase the timeout for all targets, if this is fine for the community. The other targets may want to cap the timeout to a much lower value than Xeon-SP server platform, this is their choice.