Attention is currently required from: Derek Huang, Kapil Porwal, Paul Menzel, Andrey Petrov.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74783 )
Change subject: soc/intel/common: Introduce API to get the FSP Reset Status ......................................................................
Patch Set 3:
(1 comment)
File src/soc/intel/common/fsp_reset.c:
https://review.coreboot.org/c/coreboot/+/74783/comment/fc810f5a_11d86d46 PS3, Line 66: reset_type
What about other values? do we have translate them to FSP_STATUS_RESET_REQUIRED_COLD, FSP_STATUS_RESET_REQUIRED_WARM etc.?
follow https://github.com/coreboot/coreboot/blob/3141fbade8f2918da727d72e09b9eaf425... and https://github.com/coreboot/coreboot/blob/e5e82862627eaf6d7edeb29af8b5c71d62...
the reason we need to check the global reset guid is to know about any platform specific reset between
``` case FSP_STATUS_RESET_REQUIRED_3: case FSP_STATUS_RESET_REQUIRED_4: case FSP_STATUS_RESET_REQUIRED_5: case FSP_STATUS_RESET_REQUIRED_6: case FSP_STATUS_RESET_REQUIRED_7: case FSP_STATUS_RESET_REQUIRED_8: ```
in short, if there is any other reset types than platform specific reset aka cold/warm etc. the `hob->reset_type` variable will hold the exact value.