[coreboot-gerrit] Change in coreboot[master]: mb/lenovo/*: Add support for VBOOT on 12MiB devices

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32617 )

Change subject: mb/lenovo/*: Add support for VBOOT on 12MiB devices
......................................................................

Patch Set 6:

(3 comments)

https://review.coreboot.org/c/coreboot/+/32617/6/src/mainboard/lenovo/t430/K... 
File src/mainboard/lenovo/t430/Kconfig:

https://review.coreboot.org/c/coreboot/+/32617/6/src/mainboard/lenovo/t430/K... 
PS6, Line 35: 	select HAS_RECOVERY_MRC_CACHE
Alas, this has no help text. What are its benefits?

https://review.coreboot.org/c/coreboot/+/32617/6/src/mainboard/lenovo/t430/c... 
File src/mainboard/lenovo/t430/cmos.layout:

https://review.coreboot.org/c/coreboot/+/32617/6/src/mainboard/lenovo/t430/c... 
PS6, Line 142: checksum 392 447 984
Is `vbnv` not checksummed on purpose?

https://review.coreboot.org/c/coreboot/+/32617/6/src/mainboard/lenovo/t430/v... 
File src/mainboard/lenovo/t430/vboot-rwab.fmd:

https://review.coreboot.org/c/coreboot/+/32617/6/src/mainboard/lenovo/t430/v... 
PS6, Line 5: 		SI_ME@0x3000 0x4ed000
Why the gap?