Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39430 )
Change subject: edid_fill_fb: Add row_alignment argument ......................................................................
Patch Set 13:
I think the bytes_per_line is just a hold-over from VBE modes but it's weird because it is always dependent on the display mode (which is decided by the panel, not a fundamental property of the display controller hardware). So when writing native graphics init the thing the SoC display code wants to provide is really just that alignment, and right now the SoC code always has to call this function to translate it into a resolution-dependent value after the panel resolution is known, which is a bit weird and unnecessarily roundabout.
It's more than that. The framebuffer resolution is not always the same as the panel resolution (e.g. scaling for high-reso- lution panels, multiple displays). There are cases where the controller can't even handle the panel resolution. Not seen in coreboot, though (e.g. the odd 1366x768 panels, some con- trollers can only do multiples of 8 pixels or so). And there are controllers that want the bytes-per-line programmed, so we also can't say that every driver would calculate it only for coreboot.