Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39135 )
Change subject: src/soc/tigerlake: Add memory configuration support for Jasper Lake
......................................................................
Patch Set 11:
(2 comments)
Please address below comments, rest looks good to me
https://review.coreboot.org/c/coreboot/+/39135/11/src/soc/intel/tigerlake/in...
File src/soc/intel/tigerlake/include/soc/meminit_jsl.h:
https://review.coreboot.org/c/coreboot/+/39135/11/src/soc/intel/tigerlake/in...
PS11, Line 4: * Copyright Intel Corporation 2020.
please use header as you did here
https://review.coreboot.org/c/coreboot/+/39136/9/src/mainboard/google/dedede...
https://review.coreboot.org/c/coreboot/+/39135/11/src/soc/intel/tigerlake/me...
File src/soc/intel/tigerlake/meminit_jsl.c:
https://review.coreboot.org/c/coreboot/+/39135/11/src/soc/intel/tigerlake/me...
PS11, Line 4: * Copyright Intel Corporation 2020.
same here https://review.coreboot.org/c/coreboot/+/39136/9/src/mainboard/google/dedede...
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39135
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8de502d3f05d52b9dae34e3b013c6d5b1896fa85
Gerrit-Change-Number: 39135
Gerrit-PatchSet: 11
Gerrit-Owner: Meera Ravindranath
meera.ravindranath@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Meera Ravindranath
meera.ravindranath@intel.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 29 Feb 2020 17:07:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment