Attention is currently required from: Jason Glenesk, Fred Reitberger.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69411 )
Change subject: mb/amd/birman/gpio: Configure birman GPIOs ......................................................................
Patch Set 4: Code-Review+1
(2 comments)
File src/mainboard/amd/birman/gpio.c:
https://review.coreboot.org/c/coreboot/+/69411/comment/feaf9d8f_4aeecad3 PS2, Line 31: PAD_SCI(GPIO_9, PULL_UP, EDGE_LOW),
I'm not 100% sure here either. […]
hm, i'd change this to GPI and maybe leave a comment that it's unclear if that needs to generate SCIs. not getting SCIs when expecting to get SCIs is probably a slightly better failure case then getting spurious SCIs
File src/mainboard/amd/birman/gpio.c:
https://review.coreboot.org/c/coreboot/+/69411/comment/88b6b26b_1ae96ae0 PS4, Line 19: PAD_NF_SCI(GPIO_3, GPIOxx, PULL_NONE, EDGE_LOW), i'd use PAD_SCI(GPIO_3, PULL_NONE, EDGE_LOW) here; the PAD_NF_SCI macro is only needed when the gpio mux setting is != GPIOxx. for gpio2 above the PAD_NF_SCI is needed, since the gpio mux needs to ne WAKE_L there, but this isn't the case here