Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38691 )
Change subject: soc/amd/picasso: Enable cache in bootblock
......................................................................
Patch Set 9:
(2 comments)
Patch Set 9: Code-Review+1
There is a comment on previous CL from Julius about using _Static_assert instead of the power of 2 check in Makefile. Other than that, LGTM.
Not for this change, but I think we want to set up the caching for romstage as well here?
Split the alignment check into a different CL so it doesn't block this.
There is another patch in the train for setting up romstage cache. I'll be working on that next.
https://review.coreboot.org/c/coreboot/+/38691/9//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/38691/9//COMMIT_MSG@9
PS9, Line 9: programs
devices?
Done
https://review.coreboot.org/c/coreboot/+/38691/9//COMMIT_MSG@16
PS9, Line 16: TEST=Boot trembyle to payload
Any changes with this commit (boot time, …)?
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38691
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5615ff60ca196e622a939b46276a4a0940076ebe
Gerrit-Change-Number: 38691
Gerrit-PatchSet: 9
Gerrit-Owner: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Eric Peers
epeers@google.com
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-CC: Kangheui Won
khwon@chromium.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 28 Apr 2020 17:53:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment