Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34564 )
Change subject: mb/up/squared: Fill LPDDR4 dimm info ......................................................................
Patch Set 8:
(7 comments)
https://review.coreboot.org/c/coreboot/+/34564/5//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/34564/5//COMMIT_MSG@10 PS5, Line 10:
tested on hardware?
Done
https://review.coreboot.org/c/coreboot/+/34564/4/src/mainboard/up/squared/ro... File src/mainboard/up/squared/romstage.c:
https://review.coreboot.org/c/coreboot/+/34564/4/src/mainboard/up/squared/ro... PS4, Line 39: .ch1_rank_density = LP4_8Gb_DENSITY,
ch1_rank_density = 0
Done
https://review.coreboot.org/c/coreboot/+/34564/4/src/mainboard/up/squared/ro... PS4, Line 46: .ch0_rank_density = LP4_16Gb_DENSITY,
LP4_8Gb_DENSITY
Done
https://review.coreboot.org/c/coreboot/+/34564/4/src/mainboard/up/squared/ro... PS4, Line 47: .ch1_rank_density = LP4_16Gb_DENSITY,
LP4_8Gb_DENSITY
Done
https://review.coreboot.org/c/coreboot/+/34564/4/src/mainboard/up/squared/ro... PS4, Line 48: .ch0_dual_rank = 1,
= 0
Done
https://review.coreboot.org/c/coreboot/+/34564/4/src/mainboard/up/squared/ro... PS4, Line 49: .ch1_dual_rank = 1,
= 0
Done
https://review.coreboot.org/c/coreboot/+/34564/4/src/mainboard/up/squared/ro... PS4, Line 54: LP4_32Gb_DENSITY
LP4_16Gb_DENSITY
Done