Attention is currently required from: Patrick Rudolph.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49792 )
Change subject: [Just for x86_64 build test] (LGA775 & i945)
......................................................................
Patch Set 6:
(1 comment)
File src/northbridge/intel/common/fixed_bars.h:
https://review.coreboot.org/c/coreboot/+/49792/comment/eaa60ee2_913f1088
PS6, Line 17: /* but not here , why? */
The compiler doesn't seem to complain when the macros are only
used with constants as arguments (but not variables).
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49792
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8e398c690006ae0dff9a53a61da501e3d4deeeb1
Gerrit-Change-Number: 49792
Gerrit-PatchSet: 6
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Wed, 10 Feb 2021 17:46:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment