Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/libgfxinit/+/31611 )
Change subject: [WIP] gma: Add Gemini Lake support
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
https://review.coreboot.org/c/libgfxinit/+/31611/1/common/hw-gfx-gma-config....
File common/hw-gfx-gma-config.ads.template:
https://review.coreboot.org/c/libgfxinit/+/31611/1/common/hw-gfx-gma-config....
PS1, Line 243: when Apollolake |
nit: This looks a bit inconsistent with the other lines
--
To view, visit
https://review.coreboot.org/c/libgfxinit/+/31611
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: libgfxinit
Gerrit-Branch: master
Gerrit-Change-Id: I84347130fc3fcaf33d9f3d84fab47c67899c792d
Gerrit-Change-Number: 31611
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Comment-Date: Tue, 11 Feb 2020 14:52:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment