Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46133 )
Change subject: sb/intel/lynxpoint: Enable/disable AER via Kconfig ......................................................................
Patch Set 1: Code-Review+1
(2 comments)
https://review.coreboot.org/c/coreboot/+/46133/1/src/southbridge/intel/lynxp... File src/southbridge/intel/lynxpoint/pcie.c:
https://review.coreboot.org/c/coreboot/+/46133/1/src/southbridge/intel/lynxp... PS1, Line 675: ~(1 << 29) This doesn't matter because the or-value will always set it. I think it can be dropped for clarity.
Same on the other branch
https://review.coreboot.org/c/coreboot/+/46133/1/src/southbridge/intel/lynxp... PS1, Line 676: (1 << 29) | 0x10001); nit: fits in 96 characters