Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34433 )
Change subject: mediatek/mt8183: support get current DRAM type
......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34433/7/src/mainboard/google/kukui/...
File src/mainboard/google/kukui/sdram_configs.c:
https://review.coreboot.org/c/coreboot/+/34433/7/src/mainboard/google/kukui/...
PS7, Line 44:
: int get_dram_type(void)
: {
: return params.dram_type;
: }
I think this is not really needed?
In the following change that calls this function, it's inside mt_set_emi, which has sdram_params as argument, so it can directly access params.dram_type for it.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34433
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icf875427347418f796cbf193070bf047844d2267
Gerrit-Change-Number: 34433
Gerrit-PatchSet: 7
Gerrit-Owner: huayang duan
huayangduan@gmail.com
Gerrit-Reviewer: DAWEI CHIEN
dawei.chien@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Sj Huang
sj.huang@mediatek.com
Gerrit-Reviewer: You-Cheng Syu
youcheng@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: huayang duan
huayangduan@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 31 Jul 2019 14:41:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment