Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40259 )
Change subject: soc/intel/common: Add _DSM methods for LPIT table ......................................................................
Patch Set 3:
(5 comments)
Thank you for helping with cleaning this up!
https://review.coreboot.org/c/coreboot/+/40259/3/src/soc/intel/common/acpi/l... File src/soc/intel/common/acpi/lpit.asl:
https://review.coreboot.org/c/coreboot/+/40259/3/src/soc/intel/common/acpi/l... PS3, Line 37: 2 Can we make a #define for this too? LPID_DSM_ARG2_GET_CRASH_DUMP_DEV?
https://review.coreboot.org/c/coreboot/+/40259/3/src/soc/intel/common/acpi/l... PS3, Line 43: 3 Can we make a #define for this too? LPID_DSM_ARG2_DISPLAY_OFF_NOTIFY
https://review.coreboot.org/c/coreboot/+/40259/3/src/soc/intel/common/acpi/l... PS3, Line 48: 4 Can we make a #define for this too? LPID_DSM_ARG2_DISPLAY_ON_NOTIFY
https://review.coreboot.org/c/coreboot/+/40259/3/src/soc/intel/common/acpi/l... PS3, Line 53: 5 Can we make a #define for this too? LPID_DSM_ARG2_S0IX_ENTRY
https://review.coreboot.org/c/coreboot/+/40259/3/src/soc/intel/common/acpi/l... PS3, Line 76: 6 Can we make a #define for this too? LPID_DSM_ARG2_S0IX_EXIT