Huayang Duan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34988 )
Change subject: mediatek/mt8183: Implement the dramc init setting
......................................................................
Patch Set 17:
(3 comments)
https://review.coreboot.org/c/coreboot/+/34988/8//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/34988/8//COMMIT_MSG@10
PS8, Line 10: hard init-sequence to support more frequency calibration.
those code was from mtk internal DRAM full calibration source code
Done
https://review.coreboot.org/c/coreboot/+/34988/8//COMMIT_MSG@14
PS8, Line 14: stress test pass
/usr/sbin/memtester 500M
Done
https://review.coreboot.org/c/coreboot/+/34988/14/src/soc/mediatek/mt8183/dr...
File src/soc/mediatek/mt8183/dramc_init_setting.c:
https://review.coreboot.org/c/coreboot/+/34988/14/src/soc/mediatek/mt8183/dr...
PS14, Line 1353: if (freq_group == LP4X_DDR1600)
: dramc_setting_DDR1600();
: else if (freq_group == LP4X_DDR2400)
: dramc_setting_DDR2400();
: else if (freq_group == LP4X_DDR3600)
: dramc_setting_DDR3600();
@huayang I changed to 'switch' statement. Please check https://review.coreboot. […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34988
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I756ad37e78cd1384ee0eb97e5e18c5461d73bc7b
Gerrit-Change-Number: 34988
Gerrit-PatchSet: 17
Gerrit-Owner: huayang duan
huayangduan@gmail.com
Gerrit-Reviewer: Cindy Ching
cindy.ching@mediatek.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: SJ Huang
sj.huang@mediatek.corp-partner.google.com
Gerrit-Reviewer: You-Cheng Syu
youcheng@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: huayang duan
huayangduan@gmail.com
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Huayang Duan
huayang.duan@mediatek.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 16 Sep 2019 09:51:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Comment-In-Reply-To: Huayang Duan
huayang.duan@mediatek.corp-partner.google.com
Comment-In-Reply-To: Hung-Te Lin
hungte@chromium.org
Gerrit-MessageType: comment