Attention is currently required from: Angel Pons, Riku Viitanen.
Hello Angel Pons, Jan Philipp Groß, Riku Viitanen, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/85816?usp=email
to look at the new patch set (#5).
The following approvals got outdated and were removed: Code-Review+1 by Riku Viitanen, Verified+1 by build bot (Jenkins)
Change subject: drivers/asmedia: Add code to enable AHCI for ASM1061 ......................................................................
drivers/asmedia: Add code to enable AHCI for ASM1061
The ASMedia ASM1061 seems to default to IDE mode, which seems to be the source of payloads and Linux not recognizing/booting from drives connected to it. From the behaviour of vendor firmware on the ASRock Z87 Extreme 4, the mode can be changed by setting the PCI Subclass register to either 0x06 (SATA controller) or 0x01 (IDE controller). This register seems to be read only, but can be unlocked for writing by setting bit 2 at offset 0xEC in the PCI config space.
Since the ASMEDIA_ASPM_BLACKLIST driver already existed and only matched the ASM1061, rename it to ASMEDIA_ASM1061 and add the AHCI mode setting code to it. To maintain consistency with chipset SATA ports, this is also configurable through the existing sata_mode CMOS option with the default set to AHCI.
Tested on the ASUS Maximus VI Gene.
Change-Id: I7a1470894261c7d14fadccdcade968f87f78fe23 Signed-off-by: Nicholas Chin nic.c3.14@gmail.com --- M src/drivers/asmedia/Kconfig M src/drivers/asmedia/Makefile.mk A src/drivers/asmedia/asm1061.c D src/drivers/asmedia/aspm_blacklist.c M src/mainboard/asrock/b75pro3-m/Kconfig M src/mainboard/asrock/fatal1ty_z87_professional/Kconfig M src/mainboard/asrock/h77pro4-m/Kconfig M src/mainboard/asus/h61-series/Kconfig M src/mainboard/asus/p8x7x-series/Kconfig 9 files changed, 57 insertions(+), 39 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/16/85816/5