Attention is currently required from: Martin Roth, Vitaly Rodionov, Paul Menzel, Zhuohao Lee, Karthik Ramasubramanian.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52395 )
Change subject: drivers/i2c/cs42l42: Add driver for generating device in SSDT
......................................................................
Patch Set 10: Code-Review+2
(1 comment)
File src/drivers/i2c/cs42l42/chip.h:
https://review.coreboot.org/c/coreboot/+/52395/comment/cfafc9bd_44496f81
PS7, Line 59: Default = Non-inverted
I think it is OK to mention default value, for someone who is looking at this code first time it wil […]
Generally, if it is commented as default in the chip.h file, it means that the chip driver in coreboot sets that default. I understand your point about the default recommendation to make it easier for the user. Probably say "Recommended default" instead of "Default" to make it clear that it is upto the user to set that?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52395
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7c3145b20a1ba743d91eb64b93cb001db3854c5d
Gerrit-Change-Number: 52395
Gerrit-PatchSet: 10
Gerrit-Owner: Vitaly Rodionov
vitaly.rodionov@cirrus.corp-partner.google.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Marco Chen
marcochen@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Zhuohao Lee
zhuohao@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Vitaly Rodionov
vitaly.rodionov@cirrus.corp-partner.google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Zhuohao Lee
zhuohao@google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Fri, 23 Apr 2021 13:45:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Vitaly Rodionov
vitaly.rodionov@cirrus.corp-partner.google.com
Gerrit-MessageType: comment