Attention is currently required from: Tarun Tuli, Subrata Banik, Nick Vaccaro.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69639 )
Change subject: mb/google/brya/acpi: Update NVPCF_FUNC_UPDATE_DYNAMIC_PARAMS ......................................................................
Patch Set 9:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/69639/comment/5abad975_3053fd8d PS7, Line 7: mb/google/brya/acpi: Fix which param MAGA lies and add TPPA
I've updated to the comment to reflect more accurately what we're doing (general updates of the para […]
It improved the situation, but next time, please do one commit per logical change.
Commit Message:
https://review.coreboot.org/c/coreboot/+/69639/comment/94b1125e_901c1023 PS9, Line 9: Update location of TGP (MAGA) to Params2[15:0] : Add TPPA (value of 25W) Please format this as a list.
https://review.coreboot.org/c/coreboot/+/69639/comment/8c9d6623_36c51ad1 PS9, Line 13: . : . : . Why the three lines?