[coreboot-gerrit] Change in coreboot[master]: mediatek/mt8183: Add display controller driver

[Julius Werner (Code Review)]

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31478 )

Change subject: mediatek/mt8183: Add display controller driver
......................................................................

Patch Set 22:

Sorry, I missed your pings last week.

Can you clarify how urgent this is and what the plan for deduplication is? There are plenty of functions here that are really copy&pasted 1-to-1 from MT8173. Looks like we had agreement on deduplicating at the start of June, but then nothing happened since. Can we at least clean it up a little? What deadline do you need to hit now?

Part of the problem is that not deduplicating makes this a lot harder to review. Right now, it's just a 500+ line standalone patch. If we would factor out common parts properly, there'd probably be less than 100 lines remaining which would be a lot easier to deal with.