[coreboot-gerrit] Change in ...coreboot[master]: soc/intel/cannonlake: Support different SPD read type for each slot

[Paul Fagerburg (Code Review)]

Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32513 )

Change subject: soc/intel/cannonlake: Support different SPD read type for each slot
......................................................................

Patch Set 14:

(1 comment)

https://review.coreboot.org/#/c/32513/13/src/soc/intel/cannonlake/cnl_memcfg... 
File src/soc/intel/cannonlake/cnl_memcfg_init.c:

https://review.coreboot.org/#/c/32513/13/src/soc/intel/cannonlake/cnl_memcfg... 
PS13, Line 57: 	static size_t last_set_spd_data_len;
> Or you're worried about a potential compiler problem?

The variable is static, so it will have a definite memory address. If the compiler puts it into a zero-init section, then yes, it will be zero. But if it's in an uninitialized section of memory, the contents are undefined. It is safer to explicitly initialize it. If you initialize to 0 as part of the decl, it won't even result in any extra code in the executable.