Zhuohao Lee has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44854 )
Change subject: mb/google/poppy: New SPD support for Shyvana, Shyvana-M and Leona
......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/c/coreboot/+/44854/5//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/44854/5//COMMIT_MSG@11
PS5, Line 11: "samsung_dimm_K4E6E304ED-EGCG" in Rammus memory table.
Add 3 space to align with 'Add"?
https://review.coreboot.org/c/coreboot/+/44854/5//COMMIT_MSG@13
PS5, Line 13: 166576463
b:166576463
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44854
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I82386507c4e996e0a59c26ce50de3bced45b1196
Gerrit-Change-Number: 44854
Gerrit-PatchSet: 5
Gerrit-Owner: Kane Chen
kane_chen@pegatron.corp-partner.google.com
Gerrit-Reviewer: Kane Chen
kane_chen@pegatron.corp-partner.google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Zhuohao Lee
zhuohao@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Hank Lin
hank2_lin@pegatron.corp-partner.google.com
Gerrit-CC: Ken Lu
ken_lu@pegatron.corp-partner.google.com
Gerrit-CC: Zhuohao Lee
zhuohao@google.com
Gerrit-Comment-Date: Thu, 27 Aug 2020 12:02:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment