Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Patrick Rudolph.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51159 )
Change subject: soc/intel/common/block/irq: Add support for intel_write_pci0_PRT
......................................................................
Patch Set 8:
(1 comment)
File src/soc/intel/common/block/irq/irq.c:
https://review.coreboot.org/c/coreboot/+/51159/comment/9a5dc235_b5a2d92b
PS7, Line 378: /* Map INTA->PIRQ_A, INTB->PIRQ_B, INTC->PIRQ_C, INTD->PIRQ_D */
Sorry I can make the comment a little more clear, this is how Intel does the mapping for PIC-mode IRQs (IRQ11 for INTA,INTC,INTD, and IRQ10 for INTB).
I'm not convinced. To allow the mapping we provide for the APIC mode,
FSP has to configure PIR registers (ITSS PCR) and then there is no direct
mapping from pins to PIRQs guaranteed. Or do I miss something in that
direction?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51159
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I21a4835890ca03bff83ed0e8791441b3af54cb62
Gerrit-Change-Number: 51159
Gerrit-PatchSet: 8
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Fri, 02 Apr 2021 18:18:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment
