Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33571 )
Change subject: mb/google/kukui: Add panel for Kukui
......................................................................
Patch Set 48:
(1 comment)
https://review.coreboot.org/c/coreboot/+/33571/43/src/mainboard/google/kukui...
File src/mainboard/google/kukui/panel_kukui.c:
https://review.coreboot.org/c/coreboot/+/33571/43/src/mainboard/google/kukui...
PS43, Line 111: /* Kukui didn't set panel ID correctly so we have to check. */
Do you mean rev1 didn't set it correctly?
Originally we do support P1 panel here so the comment was for that (we have to use a fake ID). Let me rephrase this.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33571
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icc16c4297eb3c6b6a4770a36661a2e3cab418048
Gerrit-Change-Number: 33571
Gerrit-PatchSet: 48
Gerrit-Owner: jitao shi
jitao.shi@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nicolas Boichat
drinkcat@chromium.org
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Peichao Li
peichao.wang@bitland.corp-partner.google.com
Gerrit-Reviewer: You-Cheng Syu
youcheng@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: jitao shi
jitao.shi@mediatek.com
Gerrit-Reviewer: yongqiang niu
yongqiang.niu@mediatek.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: SJ Huang
sj.huang@mediatek.corp-partner.google.com
Gerrit-Comment-Date: Tue, 13 Aug 2019 03:33:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment