[coreboot-gerrit] [M] Change in coreboot[main]: security/intel/txt: Verify Intel TXT required TPM2 indices presence

[Krystian Hebel (Code Review)]

Attention is currently required from: Arthur Heymans, Felix Singer, Filip Lewiński, Julius Werner, Martin Roth, Michał Kopeć, Yu-Ping Wu.

Krystian Hebel has posted comments on this change by Filip Lewiński. ( https://review.coreboot.org/c/coreboot/+/82417?usp=email )

Change subject: security/intel/txt: Verify Intel TXT required TPM2 indices presence
......................................................................

Patch Set 11:

(3 comments)

File src/security/intel/txt/common.c:

https://review.coreboot.org/c/coreboot/+/82417/comment/80bc9b17_813a7b69?usp... :
PS11, Line 14: #include <security/tpm/tss.h>
Keep includes ordered alphabetically.

https://review.coreboot.org/c/coreboot/+/82417/comment/cf6fed6f_78a935f5?usp... :
PS11, Line 426: 	/* The index could have been written already, but we don't need to care. */
Can it _not_ be written? Further code compares it against known value, so it must have a content.

https://review.coreboot.org/c/coreboot/+/82417/comment/29ecc2ad_34343494?usp... :
PS11, Line 458: 	/* The index could have been written already, but we don't need to care. */
Same as above.