12 Aug
2019
12 Aug
'19
11:16 a.m.
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34711 )
Change subject: google/mistral: LED Pattern change ......................................................................
Patch Set 8:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34711/8/src/drivers/i2c/lp5562/led_... File src/drivers/i2c/lp5562/led_lp5562_programs.c:
https://review.coreboot.org/c/coreboot/+/34711/8/src/drivers/i2c/lp5562/led_... PS8, Line 60: 11 21 C000 end
Please split out format changes from functional changes.
The formatting changes are necessary to make the tools happy. I'll see to push them to the earlier change (no idea why it only started complaining here - or did it?)
--
To view, visit https://review.coreboot.org/c/coreboot/+/34711
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibd426162f18aefae79cb390cc0c4e44de6cb6f6e
Gerrit-Change-Number: 34711
Gerrit-PatchSet: 8
Gerrit-Owner: Yuji Sasaki sasakiy@chromium.org
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Yuji Sasaki sasakiy@chromium.org
Gerrit-Reviewer: Zhihong Yu zhihongyu@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 12 Aug 2019 16:16:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-MessageType: comment