build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34939 )
Change subject: Add definition for ENV_ROMSTAGE_OR_BEFORE to <rules.h>
......................................................................
Patch Set 11:
(2 comments)
https://review.coreboot.org/c/coreboot/+/34939/11/src/include/rules.h
File src/include/rules.h:
https://review.coreboot.org/c/coreboot/+/34939/11/src/include/rules.h@274
PS11, Line 274: #define ENV_STAGE_HAS_DATA_SECTION !ENV_ROMSTAGE_OR_BEFORE
please, no space before tabs
https://review.coreboot.org/c/coreboot/+/34939/11/src/include/rules.h@278
PS11, Line 278: #define ENV_STAGE_HAS_DATA_SECTION 1
please, no space before tabs
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34939
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibd2292f922ccb9e79d10ca9bc35797048d174287
Gerrit-Change-Number: 34939
Gerrit-PatchSet: 11
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Hug
philipp@hug.cx
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-Comment-Date: Wed, 21 Aug 2019 12:21:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment