Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49301 )
Change subject: soc/intel/alderlake: Add PCH ID 0x5182
......................................................................
Patch Set 2:
(1 comment)
File src/soc/intel/common/block/lpc/lpc.c:
https://review.coreboot.org/c/coreboot/+/49301/comment/ea2aff75_6b9e53d6
PS1, Line 308: PCI_DEVICE_ID_INTEL_ADP_P_ESPI_32,
: PCI_DEVICE_ID_INTEL_ADP_P_ESPI_33,
nit: Place this up with rest of the ADP_P_ESPI above?
Done Furquan
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49301
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia331998b46abcf10e939078dea992589f09139bd
Gerrit-Change-Number: 49301
Gerrit-PatchSet: 2
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Comment-Date: Tue, 12 Jan 2021 03:50:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment