Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43718 )
Change subject: ec/system76: Add console support
......................................................................
Patch Set 3: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/43718/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/43718/2//COMMIT_MSG@9
PS2, Line 9: This adds support for line-buffered console output to System76 EC firmware.
I see. It would be good to mention this in the commit message. […]
Done, thank you!
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43718
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I861bf3e22f40dd6c3ec7ba1d73711b399358e332
Gerrit-Change-Number: 43718
Gerrit-PatchSet: 3
Gerrit-Owner: Jeremy Soller
jeremy@system76.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 22 Jul 2020 14:36:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Jeremy Soller
jeremy@system76.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment