Kevin Chiu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47734 )
Change subject: soc/amd/picasso: correct USB2 phy parameter naming problem
......................................................................
Patch Set 1:
Patch Set 1:
it seems that this patch and the next one need to be squashed together, so that the build won't fail for this one. haven't checked the parameter names yet
so maybe combine 47734/47735 to one?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47734
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I50af0d28eeb89aaca20b0d89d8a9890564d538fc
Gerrit-Change-Number: 47734
Gerrit-PatchSet: 1
Gerrit-Owner: Kevin Chiu
kevin.chiu.17802@gmail.com
Gerrit-Reviewer: Bhanu Prakash Maiya
bhanumaiya@google.com
Gerrit-Reviewer: Eric Peers
epeers@google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Keith Tzeng
keith.tzeng@quanta.corp-partner.google.com
Gerrit-Reviewer: Kevin Chiu
Kevin.Chiu@quantatw.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Sat, 21 Nov 2020 04:38:57 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment