19 Apr
2019
19 Apr
'19
9:10 a.m.
Philip Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32292 )
Change subject: mb/google/hatch: Pull up GPP_C13 for hatch and hatch_whl ......................................................................
Patch Set 6:
(1 comment)
Patch Set 5:
gpio.c files need to be added to Makefile.inc in respective folders.
Ah, yes, thanks for pointing this out.
https://review.coreboot.org/#/c/32292/4/src/mainboard/google/hatch/variants/... File src/mainboard/google/hatch/variants/baseboard/gpio.c:
https://review.coreboot.org/#/c/32292/4/src/mainboard/google/hatch/variants/... PS4, Line 150: UP_20K
Actually can you add the pull-up to override table in hatch and hatch_whl. […]
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/32292
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibc1f89fc25773220db009c6571400b01390dd756
Gerrit-Change-Number: 32292
Gerrit-PatchSet: 6
Gerrit-Owner: Philip Chen philipchen@google.com
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Philip Chen philipchen@google.com
Gerrit-Reviewer: Shelley Chen shchen@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 19 Apr 2019 07:10:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh furquan@google.com
Gerrit-MessageType: comment