Jes Klinke has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44359 )
Change subject: mainboard/google/volteer: Disable S0i3.4 if cr50 firmware is too old ......................................................................
Patch Set 19:
(3 comments)
https://review.coreboot.org/c/coreboot/+/44359/15//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/44359/15//COMMIT_MSG@24 PS15, Line 24:
It would be good to also mention the change in gpio_pm_override.
Done
https://review.coreboot.org/c/coreboot/+/44359/16//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/44359/16//COMMIT_MSG@7 PS16, Line 7: Enable long cr50 ready pulses
nit: With all the changes that have happened in the review process, this change is not really enabli […]
Done
https://review.coreboot.org/c/coreboot/+/44359/16/src/mainboard/google/volte... File src/mainboard/google/volteer/mainboard.c:
https://review.coreboot.org/c/coreboot/+/44359/16/src/mainboard/google/volte... PS16, Line 26: mainboard_config_update
mainboard_update_soc_chip_config
Done