Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48408 )
Change subject: nb/intel/sandybridge: Clean up stepping logic
......................................................................
Patch Set 4: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/48408/3/src/cpu/intel/model_206ax/m...
File src/cpu/intel/model_206ax/model_206ax.h:
https://review.coreboot.org/c/coreboot/+/48408/3/src/cpu/intel/model_206ax/m...
PS3, Line 95: }
Yeah, where can I place this instead?
There are already some functions around, e.g. one that decodes the
CPUID signature into family, modding, stepping, IIRC. It's not handy
if one just needs the stepping, though. In `arch/x86/include/arch/cpu.h`.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48408
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I27ad609eb53b96987ad5445301b5392055fa4ea1
Gerrit-Change-Number: 48408
Gerrit-PatchSet: 4
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 11 Dec 2020 00:15:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment