Attention is currently required from: SH Kim. Hello SH Kim,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/59609
to review the following change.
Change subject: mb/google/dedede: Add SAR sensor for bugzzy ......................................................................
mb/google/dedede: Add SAR sensor for bugzzy
Present 2 SX9360 SAR sensor for bugzzy.
Signed-off-by: Seunghwan Kim sh_.kim@samsung.corp-partner.google.com Signed-off-by: Gwendal Grignou gwendal@chromium.org Change-Id: I9feef9d132c60738bafb22ceb7d3468c798fab9b --- M 3rdparty/amd_blobs M 3rdparty/blobs M 3rdparty/intel-microcode M src/mainboard/google/dedede/Kconfig M src/mainboard/google/dedede/variants/bugzzy/gpio.c M src/mainboard/google/dedede/variants/bugzzy/overridetree.cb 6 files changed, 45 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/59609/1
diff --git a/3rdparty/amd_blobs b/3rdparty/amd_blobs index f638765..539d31a 160000 --- a/3rdparty/amd_blobs +++ b/3rdparty/amd_blobs @@ -1 +1 @@ -Subproject commit f638765f17cdca735b69229f4f0479562bcb7526 +Subproject commit 539d31ab9ea89084fa5edf7cc9ac3122786d5454 diff --git a/3rdparty/blobs b/3rdparty/blobs index b8e3eaf..fe7040a 160000 --- a/3rdparty/blobs +++ b/3rdparty/blobs @@ -1 +1 @@ -Subproject commit b8e3eaf7501aaa234e93a4a305bf711cf34bb0ad +Subproject commit fe7040a278642dc3d28e20eb7e7866cb6e2ac2ac diff --git a/3rdparty/intel-microcode b/3rdparty/intel-microcode index 3f97690..ee319ae 160000 --- a/3rdparty/intel-microcode +++ b/3rdparty/intel-microcode @@ -1 +1 @@ -Subproject commit 3f97690f0da8011f52209b232450a1e5c4f2e1f6 +Subproject commit ee319ae7bc59e88b60142f40a9ec1b46656de4db diff --git a/src/mainboard/google/dedede/Kconfig b/src/mainboard/google/dedede/Kconfig index 64fca47..03d64a2 100644 --- a/src/mainboard/google/dedede/Kconfig +++ b/src/mainboard/google/dedede/Kconfig @@ -7,6 +7,7 @@ select DRIVERS_I2C_GPIO_MUX select DRIVERS_I2C_HID select DRIVERS_I2C_SX9324 + select DRIVERS_I2C_SX9360 select DRIVERS_INTEL_DPTF select DRIVERS_SPI_ACPI select DRIVERS_USB_ACPI diff --git a/src/mainboard/google/dedede/variants/bugzzy/gpio.c b/src/mainboard/google/dedede/variants/bugzzy/gpio.c index a218c5e..2242eaf 100644 --- a/src/mainboard/google/dedede/variants/bugzzy/gpio.c +++ b/src/mainboard/google/dedede/variants/bugzzy/gpio.c @@ -46,6 +46,10 @@ PAD_NC(GPP_E0, NONE), /* E1 : EMR_RESET_L */ PAD_CFG_GPO(GPP_E1, 0, DEEP), + /* E10 : LTE_SAR_SENSOR_INT */ + PAD_CFG_GPI_APIC(GPP_E10, NONE, PLTRST, LEVEL, NONE), + /* E11 : WIFI_SAR_SENSOR_INT */ + PAD_CFG_GPI_APIC(GPP_E11, NONE, PLTRST, LEVEL, NONE), /* E13 : DDI0_DDC_SCL */ PAD_CFG_NF(GPP_E13, NONE, DEEP, NF1), /* E14 : DDI0_DDC_SDA */ diff --git a/src/mainboard/google/dedede/variants/bugzzy/overridetree.cb b/src/mainboard/google/dedede/variants/bugzzy/overridetree.cb index de1e46d..c64fd50 100644 --- a/src/mainboard/google/dedede/variants/bugzzy/overridetree.cb +++ b/src/mainboard/google/dedede/variants/bugzzy/overridetree.cb @@ -42,6 +42,15 @@ register "usb2_ports[4]" = "USB2_PORT_EMPTY" register "usb2_ports[5]" = "USB2_PORT_MID(OC_SKIP)" # Camera
+ register "SerialIoI2cMode" = "{ + [PchSerialIoIndexI2C0] = PchSerialIoPci, + [PchSerialIoIndexI2C1] = PchSerialIoPci, + [PchSerialIoIndexI2C2] = PchSerialIoPci, + [PchSerialIoIndexI2C3] = PchSerialIoPci, + [PchSerialIoIndexI2C4] = PchSerialIoPci, + [PchSerialIoIndexI2C5] = PchSerialIoPci, + }" + # Intel Common SoC Config #+-------------------+---------------------------+ #| Field | Value | @@ -51,10 +60,11 @@ #| | for TPM communication | #| | before memory is up | #| I2C0 | Trackpad | - #| I2C1 | Digitizer | + #| I2C1 | Digitizer, P-sensor(LTE) | #| I2C2 | Touchscreen | #| I2C3 | Camera | #| I2C4 | Audio | + #| I2C5 | P-sensor(Wifi) | #+-------------------+---------------------------+ register "common_soc_config" = "{ .panel_orientation = LB_FB_ORIENTATION_RIGHT_UP, @@ -87,6 +97,11 @@ .rise_time_ns = 175, .fall_time_ns = 8, }, + .i2c[5] = { + .speed = I2C_SPEED_FAST, + .rise_time_ns = 88, + .fall_time_ns = 8, + }, }" device domain 0 on device pci 04.0 on @@ -206,13 +221,22 @@ register "hid_desc_reg_offset" = "0x1" device i2c 0x09 on end end + chip drivers/i2c/sx9360 + register "desc" = ""SAR Proximity Sensor - LTE"" + register "irq" = "ACPI_IRQ_LEVEL_LOW(GPP_E10_IRQ)" + register "uid" = "1" + register "proxraw_strength" = "2" + register "avg_pos_strength" = "16" + register "resolution" = "1024" + device i2c 28 on end + end end # I2C #1 device pci 15.2 on chip drivers/i2c/hid register "generic.hid" = ""HX121A"" register "generic.desc" = ""HX Touchscreen"" register "generic.irq" = "ACPI_IRQ_LEVEL_LOW(GPP_D4_IRQ)" - register "generic.probed" = "1" + #register "generic.probed" = "1" register "generic.reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_D5)" register "generic.reset_delay_ms" = "120" register "generic.reset_off_delay_ms" = "2" @@ -311,6 +335,17 @@ device i2c 1a on end end end #I2C 4 + device pci 19.1 on + chip drivers/i2c/sx9360 + register "desc" = ""SAR Proximity Sensor - Wifi"" + register "irq" = "ACPI_IRQ_LEVEL_LOW(GPP_E11_IRQ)" + register "uid" = "2" + register "proxraw_strength" = "2" + register "avg_pos_strength" = "16" + register "resolution" = "1024" + device i2c 28 on end + end + end #I2C 5 device pci 1f.3 on chip drivers/generic/max98357a register "hid" = ""MX98360A""